You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/12 22:54:22 UTC
[GitHub] [druid] jon-wei opened a new pull request #9354: Fix basic auth
polling to skip retries when cachedSerializedGroupMappingMap returns 404
jon-wei opened a new pull request #9354: Fix basic auth polling to skip retries when cachedSerializedGroupMappingMap returns 404
URL: https://github.com/apache/druid/pull/9354
This PR fixes a rolling upgrade issue that occurs when druid-basic-security extension is used.
`cachedSerializedGroupMappingMap` is a new endpoint on the coordinator added by #6972 .
When a process running 0.17.0 or later is running alongside a coordinator running a version < 0.17.0, the new version process will attempt to fetch info from the ``cachedSerializedGroupMappingMap` endpoint which does not exist until the coordinator is upgraded.
This has the effect of blocking process startup until the retries for that endpoint are exhausted. The impact is worse for tasks launched during the rolling upgrade, as the overlord may kill tasks that take too long to start up.
The PR addresses this issue by having the polling mechanism stop retrying if it receives a 404 from the coordinator for the `cachedSerializedGroupMappingMap` endpoint and logging a warning message.
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #9354: Fix basic auth polling
to skip retries when cachedSerializedGroupMappingMap returns 404
Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #9354: Fix basic auth polling to skip retries when cachedSerializedGroupMappingMap returns 404
URL: https://github.com/apache/druid/pull/9354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org