You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Udi Meiri (Jira)" <ji...@apache.org> on 2020/01/11 00:05:00 UTC

[jira] [Updated] (BEAM-9091) build_release_candidate.sh never runs hub command

     [ https://issues.apache.org/jira/browse/BEAM-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Udi Meiri updated BEAM-9091:
----------------------------
    Description: 
This is due a True-False inversion bug:
https://github.com/apache/beam/blob/a20bd7e20981f0901b9f4198d6a8c36b12da7be9/release/src/main/scripts/build_release_candidate.sh#L317-L321

(It will always print: "Without hub, you need to create PR manually.")

The PR I got seems legit: https://github.com/apache/beam-site/pull/595/files

  was:
This is due a True-False inversion bug:
https://github.com/apache/beam/blob/a20bd7e20981f0901b9f4198d6a8c36b12da7be9/release/src/main/scripts/build_release_candidate.sh#L317-L321

(It will always print: "Without hub, you need to create PR manually.")

The hub command seems out of date, creating a PR against apache/beam-site instead of apache/beam.
Example: https://github.com/apache/beam-site/pull/595/files


> build_release_candidate.sh never runs hub command
> -------------------------------------------------
>
>                 Key: BEAM-9091
>                 URL: https://issues.apache.org/jira/browse/BEAM-9091
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Udi Meiri
>            Priority: Major
>
> This is due a True-False inversion bug:
> https://github.com/apache/beam/blob/a20bd7e20981f0901b9f4198d6a8c36b12da7be9/release/src/main/scripts/build_release_candidate.sh#L317-L321
> (It will always print: "Without hub, you need to create PR manually.")
> The PR I got seems legit: https://github.com/apache/beam-site/pull/595/files



--
This message was sent by Atlassian Jira
(v8.3.4#803005)