You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/02/21 14:17:23 UTC
Review Request 65728: Add test to check quotes in docker executor
health check.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
Bugs: MESOS-4812 and MESOS-8498
https://issues.apache.org/jira/browse/MESOS-4812
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
the docker executor properly deals with quotes in the command health
check to ensure that MESOS-4812 is fixed.
Diffs
-----
src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
Diff: https://reviews.apache.org/r/65728/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review197871
-----------------------------------------------------------
Bad patch!
Reviews applied: [65728, 64604, 64387, 65615, 65127, 65419, 65396, 65395, 65394, 65393]
Failed command: python support/apply-reviews.py -n -r 65615
Error:
2018-02-21 15:02:42 URL:https://reviews.apache.org/r/65615/diff/raw/ [10438/10438] -> "65615.patch" [1]
error: patch failed: src/tests/mesos.hpp:2170
error: src/tests/mesos.hpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/21712/console
- Mesos Reviewbot
On Feb. 21, 2018, 2:17 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
>
>
> Diff: https://reviews.apache.org/r/65728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review197899
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65615.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65615`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728
Relevant logs:
- [apply-review-65615-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728/logs/apply-review-65615-stdout.log):
```
error: patch failed: src/tests/mesos.hpp:2170
error: src/tests/mesos.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 21, 2018, 2:17 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
>
>
> Diff: https://reviews.apache.org/r/65728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review197910
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65615.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65615`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728
Relevant logs:
- [apply-review-65615-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728/logs/apply-review-65615-stdout.log):
```
error: patch failed: src/tests/mesos.hpp:2170
error: src/tests/mesos.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 21, 2018, 2:17 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
>
>
> Diff: https://reviews.apache.org/r/65728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review197907
-----------------------------------------------------------
FAIL: Failed to get dependent review IDs for the current patch.
Failed command: `python.exe C:\Jenkins\workspace\mesos-reviewbot-testing\Mesos\utils\get-review-ids.py -r 65728 -o C:\Users\mesos\AppData\Local\Temp\mesos_dependent_review_ids`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728
Relevant logs:
- [get-review-ids-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728/logs/get-review-ids-stdout.log):
```
Dependent review: https://reviews.apache.org/api/review-requests/64604/
Dependent review: https://reviews.apache.org/api/review-requests/64387/
Dependent review: https://reviews.apache.org/api/review-requests/65615/
Dependent review: https://reviews.apache.org/api/review-requests/65127/
Dependent review: https://reviews.apache.org/api/review-requests/65419/
Dependent review: https://reviews.apache.org/api/review-requests/65396/
Dependent review: https://reviews.apache.org/api/review-requests/65395/
Dependent review: https://reviews.apache.org/api/review-requests/65394/
Dependent review: https://reviews.apache.org/api/review-requests/65393/
```
- [get-review-ids-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728/logs/get-review-ids-stderr.log):
```
Traceback (most recent call last):
File "C:\Jenkins\workspace\mesos-reviewbot-testing\Mesos\utils\get-review-ids.py", line 51, in <module>
main()
File "C:\Jenkins\workspace\mesos-reviewbot-testing\Mesos\utils\get-review-ids.py", line 46, in main
for r_id in review_ids:
TypeError: 'NoneType' object is not iterable
```
- Mesos Reviewbot Windows
On Feb. 21, 2018, 2:17 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 2:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
>
>
> Diff: https://reviews.apache.org/r/65728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198093
-----------------------------------------------------------
PASS: Mesos patch 65728 was successfully built and tested.
Reviews applied: `['65393', '65394', '65395', '65396', '65419', '65127', '65615', '64387', '65727', '65733', '64604', '65728']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728
- Mesos Reviewbot Windows
On Feb. 21, 2018, 5:51 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 5:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
>
>
> Diff: https://reviews.apache.org/r/65728/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198157
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65393, 65394, 65395, 65396, 65419, 65127, 65615, 64387, 65727, 65733, 64604, 65728]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 22, 2018, 1:51 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 1:51 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
>
>
> Diff: https://reviews.apache.org/r/65728/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198095
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Feb. 21, 2018, 5:51 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 5:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
>
>
> Diff: https://reviews.apache.org/r/65728/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198156
-----------------------------------------------------------
PASS: Mesos patch 65728 was successfully built and tested.
Reviews applied: `['65393', '65394', '65395', '65396', '65419', '65127', '65615', '64387', '65727', '65733', '64604', '65728']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728
- Mesos Reviewbot Windows
On Feb. 22, 2018, 1:51 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 1:51 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
>
>
> Diff: https://reviews.apache.org/r/65728/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198094
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65393, 65394, 65395, 65396, 65419, 65127, 65615, 64387, 65727, 65733, 64604, 65728]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 22, 2018, 1:51 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 1:51 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
>
>
> Diff: https://reviews.apache.org/r/65728/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/
-----------------------------------------------------------
(Updated Feb. 22, 2018, 1:51 a.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
Changes
-------
Reabsed + Andy's feedback
Bugs: MESOS-4812 and MESOS-8498
https://issues.apache.org/jira/browse/MESOS-4812
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
the docker executor properly deals with quotes in the command health
check to ensure that MESOS-4812 is fixed.
Diffs (updated)
-----
src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
Diff: https://reviews.apache.org/r/65728/diff/2/
Changes: https://reviews.apache.org/r/65728/diff/1-2/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65728: Add test to check quotes in docker executor
health check.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198011
-----------------------------------------------------------
src/tests/health_check_tests.cpp
Lines 2716 (patched)
<https://reviews.apache.org/r/65728/#comment278176>
Wouldn't this be `// TODO(akagup)` now?
- Andrew Schwartzmeyer
On Feb. 21, 2018, 6:17 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 6:17 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
>
>
> Diff: https://reviews.apache.org/r/65728/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>