You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/27 22:40:31 UTC
[GitHub] apeforest commented on a change in pull request #12687: ignore a
3rd party libray in cpplint
apeforest commented on a change in pull request #12687: ignore a 3rd party libray in cpplint
URL: https://github.com/apache/incubator-mxnet/pull/12687#discussion_r221098764
##########
File path: Makefile
##########
@@ -568,7 +568,7 @@ lint: cpplint rcpplint jnilint pylint
cpplint:
3rdparty/dmlc-core/scripts/lint.py mxnet cpp include src plugin cpp-package tests \
- --exclude_path src/operator/contrib/ctc_include
+ --exclude_path src/operator/contrib/ctc_include src/operator/nn/ctc_include
Review comment:
@anirudh2290 ctc_include is a 3rd party library and I plan to move it from src/operator/contrib/ctc_include to src/operator/nn/ctc_include in my PR #12637. I need this cpp lint to be excluded from Makefile before CI can pass. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services