You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by pa...@apache.org on 2018/11/08 10:32:38 UTC
groovy git commit: GROOVY-8871: Long Constants Defined in Groovy
2.5.3 Under OpenJDK 11 Cause an IllegalAccessError
Repository: groovy
Updated Branches:
refs/heads/master da64d1b7f -> 7a41f0efd
GROOVY-8871: Long Constants Defined in Groovy 2.5.3 Under OpenJDK 11 Cause an IllegalAccessError
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/7a41f0ef
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/7a41f0ef
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/7a41f0ef
Branch: refs/heads/master
Commit: 7a41f0efd6426bf71386c7c89a1a094f2ff517fb
Parents: da64d1b
Author: Paul King <pa...@asert.com.au>
Authored: Thu Nov 8 20:32:28 2018 +1000
Committer: Paul King <pa...@asert.com.au>
Committed: Thu Nov 8 20:32:28 2018 +1000
----------------------------------------------------------------------
src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/7a41f0ef/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
index 4c7230e..c9313dd 100644
--- a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
+++ b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
@@ -113,8 +113,9 @@ public class OptimizerVisitor extends ClassCodeExpressionTransformer {
do {
name = "$const$" + index++;
} while (currentClass.getDeclaredField(name) != null);
+ // TODO consider moving initcode to <clinit> and remaking field final
field = new FieldNode(name,
- Opcodes.ACC_PRIVATE | Opcodes.ACC_STATIC | Opcodes.ACC_SYNTHETIC | Opcodes.ACC_FINAL,
+ Opcodes.ACC_PRIVATE | Opcodes.ACC_STATIC | Opcodes.ACC_SYNTHETIC,
constantExpression.getType(),
currentClass,
constantExpression);