You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Aniruddha (JIRA)" <ji...@apache.org> on 2012/05/16 22:57:08 UTC
[jira] [Created] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Aniruddha created BOOKKEEPER-263:
------------------------------------
Summary: ZK ledgers root path is hard coded
Key: BOOKKEEPER-263
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-client, bookkeeper-server
Affects Versions: 4.1.0
Reporter: Aniruddha
Assignee: Aniruddha
Fix For: 4.1.0
Attachments: BK-263.patch
Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Aniruddha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278436#comment-13278436 ]
Aniruddha commented on BOOKKEEPER-263:
--------------------------------------
Thanks for reviewing. I have updated the patch.
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Aniruddha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aniruddha updated BOOKKEEPER-263:
---------------------------------
Attachment: BK-263-v1.patch
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo resolved BOOKKEEPER-263.
----------------------------------
Resolution: Fixed
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263-v2.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279982#comment-13279982 ]
Sijie Guo commented on BOOKKEEPER-263:
--------------------------------------
the patch is pretty good to me. +1.
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263-v2.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278503#comment-13278503 ]
Sijie Guo commented on BOOKKEEPER-263:
--------------------------------------
Thanks Aniruddha for quick response.
sorry that I don't explain it more clearly. it would be better to have a method #getZkAvailableBookiesPath().
so user doesn't need to write code as below
{code}
this.bookieRegistrationPath = conf.getZkLedgersRootPath() + "/" + conf.getBookiesAvailableNode();
{code}
instead, they could write code as
{code}
this.bookieRegistrationPath = conf.getZkAvailableBookiesPath();
{code}
in AbstractionConfiguration, 'available' could be defined as a constant value, and do string concatenation in method #getZkAvailableBookiesPath().
{code}
static final String AVAILABLE_ZNODE = 'available';
public String getZkAvailableBookiesPath() {
return getZkLedgersRootPath() + "/" + AVAILABLE_ZNODE;
}
{code}
seems it could make the code clearer. How is your opinion?
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Aniruddha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278624#comment-13278624 ]
Aniruddha commented on BOOKKEEPER-263:
--------------------------------------
Yes, now it's clearer. I've updated the patch.
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282216#comment-13282216 ]
Hudson commented on BOOKKEEPER-263:
-----------------------------------
Integrated in bookkeeper-trunk #523 (See [https://builds.apache.org/job/bookkeeper-trunk/523/])
BOOKKEEPER-263: ZK ledgers root path is hard coded (Aniruddha via sijie) (Revision 1342145)
Result = ABORTED
sijie :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/BenchThroughputLatency.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Cookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263-v2.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Aniruddha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aniruddha updated BOOKKEEPER-263:
---------------------------------
Attachment: BK-263-v2.patch
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263-v2.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Aniruddha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aniruddha updated BOOKKEEPER-263:
---------------------------------
Attachment: BK-263.patch
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282198#comment-13282198 ]
Sijie Guo commented on BOOKKEEPER-263:
--------------------------------------
committed as r1342145. thanks Aniruddha.
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263-v2.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-263) ZK ledgers root path is hard
coded
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277576#comment-13277576 ]
Sijie Guo commented on BOOKKEEPER-263:
--------------------------------------
thanks Aniruddha. the patch seems good. just one comment, sees that AVAILABLE_NODE spreads over several files. could we consider moving it to a common place (which could be shared by client and server), such as AbstractConfiguration to have a method getAvailableBookiesPath(), which is similar what Hedwig did in ServerConfiguration to manage its znode path.
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira