You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/02/11 17:25:13 UTC

[GitHub] flink pull request: [FLINK-1508] Removes AkkaUtil.ask

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/384

    [FLINK-1508] Removes AkkaUtil.ask

    This PR removes the AkkaUtil.ask method and replaces all existing occurrences by explicit future handling. Furthemore, it removes the explicit actor address resolution which also introduced a blocking call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeAkkaUtilsAsk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #384
    
----
commit 9a6227eb74beb66f96ab538b69728ca2029eeaa8
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-02-10T11:21:33Z

    [FLINK-1508] [runtime] Removes AkkaUtil.ask and replaces respective calls with explicit future handling.
    
    Removes blocking calls for ActorRef retrieval in actors.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1508] Removes AkkaUtil.ask

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/384#issuecomment-74240301
  
    +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1508] Removes AkkaUtil.ask

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/384#issuecomment-74289063
  
    I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1508] Removes AkkaUtil.ask

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/384#issuecomment-74119549
  
    I vote to merge this quickly and fix issues as they appear. 
    The change touches a lot of different parts of the code and is predestined to become unmergeable quickly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1508] Removes AkkaUtil.ask

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/384


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1508] Removes AkkaUtil.ask

Posted by uce <gi...@git.apache.org>.

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/384#issuecomment-74222367
  
    Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---