[GitHub] [calcite] vlsi commented on a change in pull request #2292: [CALCITE-4429] RelOptUtil#createCastRel should throw an exception when the field count of the row type to to be converted and desired row type is not equal

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #2292:
URL: https://github.com/apache/calcite/pull/2292#discussion_r538102455



##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -829,6 +829,9 @@ public static RelNode createNullFilter(
    * instead, create a projection with the input of {@code rel} and the new
    * cast expressions.
    *
+   * <p>The field count of the desired row type and the row type to be converted
+   * should be equal. Otherwise, it would throw an exception.
+   *

Review comment:
       +1 for `@throws`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org