[GitHub] spark pull request #22164: [SPARK-23679][YARN] Setting RM_HA_URLS for AmIpFi...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22164#discussion_r213102817
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClient.scala ---
    @@ -126,4 +136,21 @@ private[spark] class YarnRMClient extends Logging {
         }
       }
     
    +  private def getUrlByRmId(conf: Configuration, rmId: String): String = {
    --- End diff --
    
    The code looks ok, but it also looks similar to this:
    
    https://github.com/apache/hadoop/blob/branch-2.6/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/amfilter/AmFilterInitializer.java
    
    I'm wondering if we could just call that class instead, somehow? It seems available in 2.6 which is the oldest version we support.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org