[GitHub] [spark] Eric5553 commented on a change in pull request #27511: [SPARK-30765][SQL] Refine base operator abstraction code style

[GitBox <gi...@apache.org>]

Eric5553 commented on a change in pull request #27511: [SPARK-30765][SQL] Refine base operator abstraction code style
URL: https://github.com/apache/spark/pull/27511#discussion_r377657438
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/WindowInPandasExec.scala
 ##########
 @@ -80,11 +80,11 @@ import org.apache.spark.util.Utils
  * window.
  */
 case class WindowInPandasExec(
-    windowExpression: Seq[NamedExpression],
-    partitionSpec: Seq[Expression],
-    orderSpec: Seq[SortOrder],
+    override val windowExpression: Seq[NamedExpression],
+    override val partitionSpec: Seq[Expression],
 
 Review comment:
   @HyukjinKwon @cloud-fan  Thanks! I dropped most changes based on this comment https://github.com/apache/spark/pull/27368#discussion_r376925299. So current refactor rules are:
   
   1. If abstract class or trait defined with `def`, then no override needed in derived class.
   2. Change `HashJoin` definition to `def` to avoid `override` in derived classes.
   3. Remove abstract class constructer part of `EvalPythonExec` `WindowExecBase` to sync with other operator code style. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org