You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/08 22:08:51 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #12910: Fix return type in prev-date context variables

kaxil commented on a change in pull request #12910:
URL: https://github.com/apache/airflow/pull/12910#discussion_r538844288



##########
File path: airflow/models/taskinstance.py
##########
@@ -773,7 +773,7 @@ def get_previous_start_date(
         """
         self.log.debug("previous_start_date was called")
         prev_ti = self.get_previous_ti(state=state, session=session)
-        return prev_ti and prev_ti.start_date
+        return prev_ti and prev_ti.start_date and pendulum.instance(prev_ti.start_date)

Review comment:
       Shouldn't this be:
   ```suggestion
           return prev_ti and pendulum.instance(prev_ti.start_date)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org