You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/19 10:39:05 UTC
[GitHub] gaborgsomogyi commented on issue #23612: [SPARK-26686][SS] Remove
unnecessary KafkaSourceProvider parameter lowercase conversion
gaborgsomogyi commented on issue #23612: [SPARK-26686][SS] Remove unnecessary KafkaSourceProvider parameter lowercase conversion
URL: https://github.com/apache/spark/pull/23612#issuecomment-465079440
As the API is not explicitly stating that it provides lowercase parameters better to keep sometimes double conversion for safety reasons.
The bad part is there are code lines which are depending on the assumption that these APIs providing lowercase parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org