You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hervé Boutemy (JIRA)" <ji...@apache.org> on 2018/01/06 01:06:00 UTC

[jira] [Closed] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()

     [ https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hervé Boutemy closed MPLUGIN-331.
---------------------------------
    Resolution: Fixed
      Assignee: Hervé Boutemy

PR merged
https://gitbox.apache.org/repos/asf?p=maven-plugin-tools.git&a=commit&h=839eb57e20f0c43356d0055c40724c13da48b975

Thank you for this excellent collaboration

> Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MPLUGIN-331
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-331
>             Project: Maven Plugin Tools
>          Issue Type: Task
>          Components: Plugin Plugin
>            Reporter: Peter Palaga
>            Assignee: Hervé Boutemy
>             Fix For: 3.5.1
>
>
> {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently reads
> {code}
> return "maven-plugin".equals( project.getPackaging() );
> {code}
> I propose to change it to 
> {code}
> return "maven-plugin".equals( project.getPackaging() )
>                 || "takari-maven-plugin".equals( project.getPackaging() );
> {code}
> so that also takari-maven-plugins are supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)