[GitHub] [ozone] adoroszlai commented on a diff in pull request #3672: HDDS-7114. CHAINED replication-type should be removed from help message

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3672:
URL: https://github.com/apache/ozone/pull/3672#discussion_r947723284


##########
pom.xml:
##########
@@ -1663,6 +1663,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
           <version>${proto-backwards-compatibility.version}</version>
           <configuration>
             <protoSourceRoot>${basedir}/target/classes</protoSourceRoot>
+            <allowBreakingChanges>true</allowBreakingChanges>

Review Comment:
   I don't think we should add this option.  The whole point of backwards compatibility check is to prevent breaking changes.



##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -267,7 +267,6 @@ message AddScmResponseProto {
 enum ReplicationType {
     RATIS = 1;
     STAND_ALONE = 2;
-    CHAINED = 3;

Review Comment:
   I think we should keep this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org