general/1827: mod_mime_magic -- Missing Problem Filename in Error Report

["M.D.Parker" <md...@netcom.com>]

>Number:         1827
>Category:       general
>Synopsis:       mod_mime_magic -- Missing Problem Filename in Error Report
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Feb 17 18:50:00 PST 1998
>Last-Modified:
>Originator:     mdpc@netcom.com
>Organization:
apache
>Release:        1.3b3
>Environment:
Linux/UNIX -- Bug is generic however
>Description:
An error in the log simply is indicated as "read failed" without any note of
the filename involved.

BTW, the BUG reporting database does not have a mod_mime_magic catagory!  HINT:
Maybe it should?
>How-To-Repeat:
oh yes...
>Fix:
Context Diff Below to put the filename into the error message.

*** mod_mime_magic.c    Tue Feb 17 18:33:50 1998
--- mod_mime_magic.c.dist       Tue Feb 17 18:33:16 1998
***************
*** 2235,2241 ****
      *newch = (unsigned char *) palloc(r->pool, n);
      if ((n = read(fileno(fout), *newch, n)) <= 0) {
        destroy_pool(sub_pool);
!       aplog_error(APLOG_MARK, APLOG_ERR, r->server, MODNAME ": read failed %s",r->filename);
        return -1;
      }
      destroy_pool(sub_pool);
--- 2235,2241 ----
      *newch = (unsigned char *) palloc(r->pool, n);
      if ((n = read(fileno(fout), *newch, n)) <= 0) {
        destroy_pool(sub_pool);
!       aplog_error(APLOG_MARK, APLOG_ERR, r->server, MODNAME ": read failed");
        return -1;
      }
      destroy_pool(sub_pool);
%0
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <ap...@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]