[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #16248: [fix] [transaction] Cmd-Subscribe and Cmd-Producer will not succeed even after 100 retries

[GitBox <gi...@apache.org>]

nicoloboschi commented on code in PR #16248:
URL: https://github.com/apache/pulsar/pull/16248#discussion_r907808461


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -131,7 +132,12 @@ public void recoverComplete() {
                                 maxReadPosition = (PositionImpl) topic.getManagedLedger().getLastConfirmedEntry();
                             }
                             if (!changeToReadyState()) {
-                                log.error("[{}]Transaction buffer recover fail", topic.getName());
+                                log.error("[{}]Transaction buffer recover fail, current state: {}",
+                                        topic.getName(), getState());
+                                transactionBufferFuture.completeExceptionally
+                                        (new TransactionBufferException.TransactionBufferRecoverException(
+                                                "Transaction buffer recover fail, change state to Ready failure."

Review Comment:
   ```suggestion
                                                   "Transaction buffer recover failed to change the status to Ready,"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org