You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/01 10:36:11 UTC

[GitHub] [flink] ZhangChaoming opened a new pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

ZhangChaoming opened a new pull request #19325:
URL: https://github.com/apache/flink/pull/19325


   
   ## What is the purpose of the change
   
   Add DATE_ADD supported in SQL & Table API.
   
   ## Brief change log
   
   Add DATE_ADD supported in SQL & Table API.
   
   ## Verifying this change
   
   This change added tests and can be verified in `TemporalTypesTest#testValidDateAdd`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103) 
   * c7a4818ca962077729ea6238fbaae36c9ee0ab0a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103) 
   * c7a4818ca962077729ea6238fbaae36c9ee0ab0a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] ZhangChaoming commented on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
ZhangChaoming commented on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1086557594


   @slinkydeveloper OK, I try use new stack.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa1079ff065cc39c0eea0cff859600237838c25d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34162",
       "triggerID" : "aa1079ff065cc39c0eea0cff859600237838c25d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c7a4818ca962077729ea6238fbaae36c9ee0ab0a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110) 
   * aa1079ff065cc39c0eea0cff859600237838c25d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34162) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103) 
   * c7a4818ca962077729ea6238fbaae36c9ee0ab0a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c7a4818ca962077729ea6238fbaae36c9ee0ab0a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on a change in pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #19325:
URL: https://github.com/apache/flink/pull/19325#discussion_r840500139



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/time.scala
##########
@@ -300,3 +300,25 @@ case class ToTimestampLtz(
 
   override private[flink] def resultType = SqlTimeTypeInfo.TIMESTAMP
 }
+
+case class DateAdd(

Review comment:
       This stack is deprecated, please remove this code. You need to add the type inference and return type inference to `BuiltInFunctionDefinitions`,

##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/converters/CustomizedConverters.java
##########
@@ -48,6 +48,7 @@
         CONVERTERS.put(
                 BuiltInFunctionDefinitions.TEMPORAL_OVERLAPS, new TemporalOverlapsConverter());
         CONVERTERS.put(BuiltInFunctionDefinitions.TIMESTAMP_DIFF, new TimestampDiffConverter());
+        CONVERTERS.put(BuiltInFunctionDefinitions.DATE_ADD, new DateAddConvertor());

Review comment:
       I think you don't need this if you use the new stack

##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -1703,6 +1703,39 @@ class TemporalTypesTest extends ExpressionTestBase {
         " Supported form(s): 'TIMESTAMPDIFF(<ANY>, <DATETIME>, <DATETIME>)'")
   }
 
+  @Test
+  def testValidDateAdd(): Unit = {

Review comment:
       Please add the tests to the new test stack (`BuiltInFunctionTestBase`)

##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java
##########
@@ -1689,6 +1690,24 @@ public static int subtractMonths(long t0, long t1) {
         return x;
     }
 
+    public static String dateAdd(String startDate, int daysNumber) {
+        long startMillSecond;
+        try {
+            startMillSecond = FORMATTER_CACHE.get(DATE_FORMAT_STRING).parse(startDate).getTime();
+        } catch (ParseException e) {
+            try {
+                startMillSecond =
+                        FORMATTER_CACHE.get(TIMESTAMP_FORMAT_STRING).parse(startDate).getTime();
+            } catch (ParseException parseException) {
+                return null;

Review comment:
       These methods should fail, rather than returning null. You can then use `fallibleMethodGen` in the codegen




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103) 
   * c7a4818ca962077729ea6238fbaae36c9ee0ab0a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa1079ff065cc39c0eea0cff859600237838c25d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34162",
       "triggerID" : "aa1079ff065cc39c0eea0cff859600237838c25d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa1079ff065cc39c0eea0cff859600237838c25d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34162) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34103",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110",
       "triggerID" : "c7a4818ca962077729ea6238fbaae36c9ee0ab0a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "aa1079ff065cc39c0eea0cff859600237838c25d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aa1079ff065cc39c0eea0cff859600237838c25d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c7a4818ca962077729ea6238fbaae36c9ee0ab0a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34110) 
   * aa1079ff065cc39c0eea0cff859600237838c25d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #19325: [FLINK-26943][table] Add DATE_ADD supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19325:
URL: https://github.com/apache/flink/pull/19325#issuecomment-1085740500


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "98a41d864a79db2e1c6990b2a16788d69b720da8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 98a41d864a79db2e1c6990b2a16788d69b720da8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org