You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "jonmeredith (via GitHub)" <gi...@apache.org> on 2023/02/10 17:29:57 UTC

[GitHub] [cassandra] jonmeredith opened a new pull request, #2152: CASSANDRA-18242 4.1

jonmeredith opened a new pull request, #2152:
URL: https://github.com/apache/cassandra/pull/2152

   See https://issues.apache.org/jira/browse/CASSANDRA-18242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] dcapwell commented on a diff in pull request #2152: CASSANDRA-18242 4.1

Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #2152:
URL: https://github.com/apache/cassandra/pull/2152#discussion_r1103313916


##########
ide/idea/workspace.xml:
##########
@@ -173,7 +182,26 @@
       <option name="MAIN_CLASS_NAME" value="" />
       <option name="METHOD_NAME" value="" />
       <option name="TEST_OBJECT" value="class" />
-      <option name="VM_PARAMETERS" value="-Dcassandra.config=file://$PROJECT_DIR$/test/conf/cassandra.yaml -Dlogback.configurationFile=file://$PROJECT_DIR$/test/conf/logback-test.xml -Dcassandra.logdir=$PROJECT_DIR$/build/test/logs -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin -Dlegacy-sstable-root=$PROJECT_DIR$/test/data/legacy-sstables -Dinvalid-legacy-sstable-root=$PROJECT_DIR$/test/data/invalid-legacy-sstables -Dcassandra.ring_delay_ms=1000 -Dcassandra.skip_sync=true -ea -XX:MaxMetaspaceSize=384M -XX:SoftRefLRUPolicyMSPerMB=0 -XX:ActiveProcessorCount=2 -Dcassandra.strict.runtime.checks=true -Dlegacy-sstable-root=$PROJECT_DIR$/test/data/legacy-sstables -Dinvalid-legacy-sstable-root=$PROJECT_DIR$/test/data/invalid-legacy-sstables -Dmigration-sstable-root=$PROJECT_DIR$/test/data/migration-sstables -Dcassandra.ring_delay_ms=1000 -Dcassandra.tolerate_sstable_size=true -Dcassandra.skip_sync=true -Dcassandra.reads.thresholds.coordinator.defensive_checks_enabled=true -Dcassandra.use_n
 ix_recursive_delete=true -Dcassandra.test.messagingService.nonGracefulShutdown=true -Dcassandra.test.flush_local_schema_changes=false " />
+      <option name="VM_PARAMETERS" value="
+                                          -Dcassandra.config=file://$PROJECT_DIR$/test/conf/cassandra.yaml
+                                          -Dcassandra.logdir=$PROJECT_DIR$/build/test/logs
+                                          -Dcassandra.reads.thresholds.coordinator.defensive_checks_enabled=true
+                                          -Dcassandra.ring_delay_ms=1000
+                                          -Dcassandra.tolerate_sstable_size=true
+                                          -Dcassandra.skip_sync=true
+                                          -Dcassandra.strict.runtime.checks=true
+                                          -Dcassandra.test.flush_local_schema_changes=false
+                                          -Dcassandra.test.messagingService.nonGracefulShutdown=true
+                                          -Dcassandra.use_nix_recursive_delete=true
+                                          -Dinvalid-legacy-sstable-root=$PROJECT_DIR$/test/data/invalid-legacy-sstables
+                                          -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin
+                                          -Dlegacy-sstable-root=$PROJECT_DIR$/test/data/legacy-sstables
+                                          -Dlogback.configurationFile=file://$PROJECT_DIR$/test/conf/logback-test.xml
+                                          -Dmigration-sstable-root=$PROJECT_DIR$/test/data/migration-sstables
+                                          -XX:ActiveProcessorCount=2
+                                          -XX:SoftRefLRUPolicyMSPerMB=0
+                                          -ea -XX:MaxMetaspaceSize=384M

Review Comment:
   new line plz



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] jonmeredith closed pull request #2152: CASSANDRA-18242 4.1

Posted by "jonmeredith (via GitHub)" <gi...@apache.org>.
jonmeredith closed pull request #2152: CASSANDRA-18242 4.1
URL: https://github.com/apache/cassandra/pull/2152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org