You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/09 18:43:50 UTC

[GitHub] [beam] lostluck commented on a diff in pull request #17814: [BEAM-14406] Drain test for SDF truncation in Go SDK

lostluck commented on code in PR #17814:
URL: https://github.com/apache/beam/pull/17814#discussion_r893846108


##########
sdks/go/test/integration/integration.go:
##########
@@ -154,6 +164,8 @@ var dataflowFilters = []string{
 	// Dataflow does not automatically terminate the TestCheckpointing pipeline when
 	// complete.
 	"TestCheckpointing",
+	// Dataflow does not drain jobs by itself.

Review Comment:
   I'll note that we can add a programatic bit that could drain the job automatically, in particular for this test. But that's a fair amount of work, since we'd need to provide access to the JobID, and the Dataflow client, via some kind of "running job" wrapper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org