You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2024/12/27 02:24:59 UTC

(kafka) branch 4.0 updated: KAFKA-18352: Add back DeleteGroups v0, it incorrectly tagged as deprecated (#18324)

This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/4.0 by this push:
     new f196fd95efc KAFKA-18352: Add back DeleteGroups v0, it incorrectly tagged as deprecated (#18324)
f196fd95efc is described below

commit f196fd95efc32079af1e66232722177a2852931e
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Thu Dec 26 16:53:50 2024 -0800

    KAFKA-18352: Add back DeleteGroups v0, it incorrectly tagged as deprecated (#18324)
    
    The Sarama version listed in the KIP only supports v0.
    
    Reviewers: Chia-Ping Tsai <ch...@gmail.com>
---
 clients/src/main/resources/common/message/DeleteGroupsRequest.json  | 4 +---
 clients/src/main/resources/common/message/DeleteGroupsResponse.json | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/clients/src/main/resources/common/message/DeleteGroupsRequest.json b/clients/src/main/resources/common/message/DeleteGroupsRequest.json
index 61a0749514c..1ac6a053e63 100644
--- a/clients/src/main/resources/common/message/DeleteGroupsRequest.json
+++ b/clients/src/main/resources/common/message/DeleteGroupsRequest.json
@@ -18,12 +18,10 @@
   "type": "request",
   "listeners": ["zkBroker", "broker"],
   "name": "DeleteGroupsRequest",
-  // Version 0 was removed in Apache Kafka 4.0, Version 1 is the new baseline.
-  //
   // Version 1 is the same as version 0.
   //
   // Version 2 is the first flexible version.
-  "validVersions": "1-2",
+  "validVersions": "0-2",
   "flexibleVersions": "2+",
   "fields": [
     { "name": "GroupsNames", "type": "[]string", "versions": "0+", "entityType": "groupId",
diff --git a/clients/src/main/resources/common/message/DeleteGroupsResponse.json b/clients/src/main/resources/common/message/DeleteGroupsResponse.json
index dd85930a2a9..168cde03ba3 100644
--- a/clients/src/main/resources/common/message/DeleteGroupsResponse.json
+++ b/clients/src/main/resources/common/message/DeleteGroupsResponse.json
@@ -17,12 +17,10 @@
   "apiKey": 42,
   "type": "response",
   "name": "DeleteGroupsResponse",
-  // Version 0 was removed in Apache Kafka 4.0, Version 1 is the new baseline.
-  //
   // Starting in version 1, on quota violation, brokers send out responses before throttling.
   //
   // Version 2 is the first flexible version.
-  "validVersions": "1-2",
+  "validVersions": "0-2",
   "flexibleVersions": "2+",
   "fields": [
     { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+",