You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org> on 2011/03/10 01:15:00 UTC

[jira] Created: (TRINIDAD-2057) UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context

UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context
------------------------------------------------------------------------------------------------------------------------

                 Key: TRINIDAD-2057
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2057
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 1.2.15-core , 2.0.0-beta-3
            Reporter: Blake Sullivan


Due to the way the RowKeySets for these components are implemented, they need to set the CollectionModel that the component is attached to when the RowKeySet is created.  Since the CollectionModel may be EL-bound, this means that the attributes can only be fetched when the component is in context.  This is different than how things are supposed to work in JSF, where an attribute should only need to be fetched in context if the attribute is EL-bound

In the short term, the fix is to hack on the RowKeySetAttributeChange, but the longer term fix is to fix these components.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (TRINIDAD-2057) UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context

Posted by "Gary VanMatre (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary VanMatre updated TRINIDAD-2057:
------------------------------------

    Status: Patch Available  (was: Open)

> UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2057
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2057
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.15-core , 2.0.0-beta-3
>            Reporter: Blake Sullivan
>            Assignee: Blake Sullivan
>         Attachments: trin_2057_1_2_x.diff, trin_2057_2_x.diff
>
>
> Due to the way the RowKeySets for these components are implemented, they need to set the CollectionModel that the component is attached to when the RowKeySet is created.  Since the CollectionModel may be EL-bound, this means that the attributes can only be fetched when the component is in context.  This is different than how things are supposed to work in JSF, where an attribute should only need to be fetched in context if the attribute is EL-bound
> In the short term, the fix is to hack on the RowKeySetAttributeChange, but the longer term fix is to fix these components.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (TRINIDAD-2057) UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005716#comment-13005716 ] 

Scott O'Bryan commented on TRINIDAD-2057:
-----------------------------------------

Blake's patch was not able to be applied cleanly to trunk but Garry's was.

> UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2057
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2057
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.15-core , 2.0.0-beta-3
>            Reporter: Blake Sullivan
>            Assignee: Scott O'Bryan
>         Attachments: RowKey-1.2.12.5.0-branch.patch, trin_2057_1_2_x.diff, trin_2057_2_x.diff
>
>
> Due to the way the RowKeySets for these components are implemented, they need to set the CollectionModel that the component is attached to when the RowKeySet is created.  Since the CollectionModel may be EL-bound, this means that the attributes can only be fetched when the component is in context.  This is different than how things are supposed to work in JSF, where an attribute should only need to be fetched in context if the attribute is EL-bound
> In the short term, the fix is to hack on the RowKeySetAttributeChange, but the longer term fix is to fix these components.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (TRINIDAD-2057) UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context

Posted by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005452#comment-13005452 ] 

Blake Sullivan commented on TRINIDAD-2057:
------------------------------------------

Fixed in 1.2.12.5 in revision 1080420

> UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2057
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2057
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.15-core , 2.0.0-beta-3
>            Reporter: Blake Sullivan
>            Assignee: Blake Sullivan
>         Attachments: RowKey-1.2.12.5.0-branch.patch, trin_2057_1_2_x.diff, trin_2057_2_x.diff
>
>
> Due to the way the RowKeySets for these components are implemented, they need to set the CollectionModel that the component is attached to when the RowKeySet is created.  Since the CollectionModel may be EL-bound, this means that the attributes can only be fetched when the component is in context.  This is different than how things are supposed to work in JSF, where an attribute should only need to be fetched in context if the attribute is EL-bound
> In the short term, the fix is to hack on the RowKeySetAttributeChange, but the longer term fix is to fix these components.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira