You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Percy Camilo Triveño Aucahuasi (Jira)" <ji...@apache.org> on 2022/10/14 22:42:00 UTC

[jira] [Commented] (ARROW-17599) [C++] ReadRangeCache should not retain data after read

    [ https://issues.apache.org/jira/browse/ARROW-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617987#comment-17617987 ] 

Percy Camilo Triveño Aucahuasi commented on ARROW-17599:
--------------------------------------------------------

Follow up ticket:

https://issues.apache.org/jira/browse/ARROW-18065

> [C++] ReadRangeCache should not retain data after read
> ------------------------------------------------------
>
>                 Key: ARROW-17599
>                 URL: https://issues.apache.org/jira/browse/ARROW-17599
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Weston Pace
>            Assignee: Percy Camilo Triveño Aucahuasi
>            Priority: Major
>              Labels: good-second-issue, pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> I've added a unit test of the issue here: https://github.com/westonpace/arrow/tree/experiment/read-range-cache-retention
> We use the ReadRangeCache for pre-buffering IPC and parquet files.  Sometimes those files are quite large (gigabytes).  The usage is roughly:
> for X in num_row_groups:
>   CacheAllThePiecesWeNeedForRowGroupX
>   WaitForPiecesToArriveForRowGroupX
>   ReadThePiecesWeNeedForRowGroupX
> However, once we've read in row group X and passed it on to Acero, etc. we do not release the data for row group X.  The read range cache's entries vector still holds a pointer to the buffer.  The data is not released until the file reader itself is destroyed which only happens when we have finished processing an entire file.
> This leads to excessive memory usage when pre-buffering is enabled.
> This could potentially be a little difficult to implement because a single read range's cache entry could be shared by multiple ranges so we will need some kind of reference counting to know when we have fully finished with an entry and can release it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)