[GitHub] [iotdb] ericpai commented on a diff in pull request #6661: [IOTDB-3784] tag aggregation

[GitBox <gi...@apache.org>]

ericpai commented on code in PR #6661:
URL: https://github.com/apache/iotdb/pull/6661#discussion_r958585426


##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGCachedImpl.java:
##########
@@ -669,6 +670,13 @@ protected void collectMeasurement(IMeasurementMNode node) {
               // only when user query with alias, the alias in path will be set
               path.setMeasurementAlias(node.getAlias());
             }
+            if (tagManager != null) {
+              try {
+                path.setTagMap(tagManager.readTagFile(node.getOffset()).getLeft());

Review Comment:
   @cornmonster @MarcosZyk I have removed those codes about TagManager usage. Now the `GROUP BY TAG` query may have a low performance on tag querying, but we haven't benchmarked it yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org