You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/02/03 00:49:24 UTC

Review Request: Fix bug that crashed a master is a slave attempted to re-register with more than one task running in the same executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3744/
-----------------------------------------------------------

Review request for mesos, Matei Zaharia and John Sirois.


Summary
-------

Fix bug that crashed a master is a slave attempted to re-register with more than one task running in the same executor. Discovered while upgrading a cluster at Twitter.


Diffs
-----

  src/master/master.cpp b56c732 

Diff: https://reviews.apache.org/r/3744/diff


Testing
-------


Thanks,

Benjamin


Re: Review Request: Fix bug that crashed a master is a slave attempted to re-register with more than one task running in the same executor.

Posted by Bill Farner <bi...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3744/#review4784
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/3744/#comment10516>

    s/try and/try to/



src/master/master.cpp
<https://reviews.apache.org/r/3744/#comment10517>

    consider if (A && B)


- Bill


On 2012-02-02 23:49:24, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3744/
> -----------------------------------------------------------
> 
> (Updated 2012-02-02 23:49:24)
> 
> 
> Review request for mesos, Matei Zaharia and John Sirois.
> 
> 
> Summary
> -------
> 
> Fix bug that crashed a master is a slave attempted to re-register with more than one task running in the same executor. Discovered while upgrading a cluster at Twitter.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b56c732 
> 
> Diff: https://reviews.apache.org/r/3744/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>