[jira] [Commented] (CASSANDRA-4312) fix OOM with ReadMessageTest.testNoCommitLog

["Yuki Morishita (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290232#comment-13290232 ] 

Yuki Morishita commented on CASSANDRA-4312:
-------------------------------------------

+1 with nit: you need to remove whitespaces on empty row.
                
> fix OOM with ReadMessageTest.testNoCommitLog
> --------------------------------------------
>
>                 Key: CASSANDRA-4312
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4312
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.2
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.2
>
>         Attachments: fix_oom_in_readmessagetest.txt
>
>
> this test can throw OOMs, because it uses a FileReader and readLine to read the commit log. However, some commit logs are fully allocated, but not initialized, (all 0s) so finding an EOL means reading 134M of data. Even for commit logs that have data they really aren't filereader-type streams.
> changed to do simple byte finding in the streams instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira