You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/09/17 20:44:34 UTC

svn commit: r1172045 - in /james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server: POP3HandlerConfiguration.java POP3HandlerConfigurationData.java POP3Protocol.java POP3Session.java POP3SessionImpl.java netty/POP3Server.java

Author: norman
Date: Sat Sep 17 18:44:33 2011
New Revision: 1172045

URL: http://svn.apache.org/viewvc?rev=1172045&view=rev
Log:
Rename POP3HandlerConfigurationData to POP3HandlerConfiguration and remove one not needed method

Added:
    james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java   (contents, props changed)
      - copied, changed from r1171924, james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfigurationData.java
Removed:
    james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfigurationData.java
Modified:
    james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Protocol.java
    james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Session.java
    james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3SessionImpl.java
    james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3Server.java

Copied: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java (from r1171924, james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfigurationData.java)
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java?p2=james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java&p1=james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfigurationData.java&r1=1171924&r2=1172045&rev=1172045&view=diff
==============================================================================
--- james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfigurationData.java (original)
+++ james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java Sat Sep 17 18:44:33 2011
@@ -22,7 +22,7 @@ package org.apache.james.pop3server;
 /**
  * Provides a number of server-wide constant values to the POP3Handlers
  */
-public interface POP3HandlerConfigurationData {
+public interface POP3HandlerConfiguration {
 
     /**
      * Returns the service wide hello name
@@ -32,13 +32,6 @@ public interface POP3HandlerConfiguratio
     String getHelloName();
 
     /**
-     * Returns the service wide reset length in bytes.
-     * 
-     * @return the reset length
-     */
-    int getResetLength();
-
-    /**
      * Return if starttls is supported by the POP3Server
      * 
      * @return startTLSSupported

Propchange: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java
------------------------------------------------------------------------------
    cvs2svn:cvs-rev = 1.1.4.3

Propchange: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3HandlerConfiguration.java
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Modified: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Protocol.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Protocol.java?rev=1172045&r1=1172044&r2=1172045&view=diff
==============================================================================
--- james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Protocol.java (original)
+++ james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Protocol.java Sat Sep 17 18:44:33 2011
@@ -30,10 +30,10 @@ import org.slf4j.Logger;
 public class POP3Protocol implements Protocol{
 
     private ProtocolHandlerChain chain;
-    private POP3HandlerConfigurationData config;
+    private POP3HandlerConfiguration config;
     private Logger logger;
     
-    public POP3Protocol(ProtocolHandlerChain chain, POP3HandlerConfigurationData config, Logger logger) {
+    public POP3Protocol(ProtocolHandlerChain chain, POP3HandlerConfiguration config, Logger logger) {
         this.chain = chain;
         this.config = config;
         this.logger = logger;

Modified: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Session.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Session.java?rev=1172045&r1=1172044&r2=1172045&view=diff
==============================================================================
--- james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Session.java (original)
+++ james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3Session.java Sat Sep 17 18:44:33 2011
@@ -48,7 +48,7 @@ public interface POP3Session extends TLS
      * 
      * @return POP3HandlerConfigurationData
      */
-    POP3HandlerConfigurationData getConfigurationData();
+    POP3HandlerConfiguration getConfigurationData();
 
     /**
      * Returns the current handler state

Modified: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3SessionImpl.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3SessionImpl.java?rev=1172045&r1=1172044&r2=1172045&view=diff
==============================================================================
--- james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3SessionImpl.java (original)
+++ james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/POP3SessionImpl.java Sat Sep 17 18:44:33 2011
@@ -31,7 +31,7 @@ import org.slf4j.Logger;
  * {@link POP3Session} implementation which use Netty
  */
 public class POP3SessionImpl extends AbstractSession implements POP3Session {
-    private POP3HandlerConfigurationData configData;
+    private POP3HandlerConfiguration configData;
 
     private Map<String, Object> state = new HashMap<String, Object>();
 
@@ -40,7 +40,7 @@ public class POP3SessionImpl extends Abs
     private MessageManager mailbox;
 
     
-    public POP3SessionImpl(Logger logger, ProtocolTransport transport, POP3HandlerConfigurationData configData) {
+    public POP3SessionImpl(Logger logger, ProtocolTransport transport, POP3HandlerConfiguration configData) {
         super(logger, transport);
         this.configData = configData;
     }
@@ -50,7 +50,7 @@ public class POP3SessionImpl extends Abs
      * 
      * @see org.apache.james.pop3server.POP3Session#getConfigurationData()
      */
-    public POP3HandlerConfigurationData getConfigurationData() {
+    public POP3HandlerConfiguration getConfigurationData() {
         return configData;
     }
 

Modified: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3Server.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3Server.java?rev=1172045&r1=1172044&r2=1172045&view=diff
==============================================================================
--- james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3Server.java (original)
+++ james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3Server.java Sat Sep 17 18:44:33 2011
@@ -20,7 +20,7 @@ package org.apache.james.pop3server.nett
 
 import java.nio.charset.Charset;
 
-import org.apache.james.pop3server.POP3HandlerConfigurationData;
+import org.apache.james.pop3server.POP3HandlerConfiguration;
 import org.apache.james.pop3server.POP3Protocol;
 import org.apache.james.pop3server.POP3Response;
 import org.apache.james.pop3server.core.CoreCmdHandlerLoader;
@@ -45,7 +45,7 @@ public class POP3Server extends Abstract
     /**
      * The configuration data to be passed to the handler
      */
-    private POP3HandlerConfigurationData theConfigData = new POP3HandlerConfigurationDataImpl();
+    private POP3HandlerConfiguration theConfigData = new POP3HandlerConfigurationDataImpl();
     private BasicChannelUpstreamHandler coreHandler;
     
     @Override
@@ -66,24 +66,17 @@ public class POP3Server extends Abstract
     /**
      * A class to provide POP3 handler configuration to the handlers
      */
-    private class POP3HandlerConfigurationDataImpl implements POP3HandlerConfigurationData {
+    private class POP3HandlerConfigurationDataImpl implements POP3HandlerConfiguration {
 
         /**
-         * @see org.apache.james.pop3server.POP3HandlerConfigurationData#getHelloName()
+         * @see org.apache.james.pop3server.POP3HandlerConfiguration#getHelloName()
          */
         public String getHelloName() {
             return POP3Server.this.getHelloName();
         }
 
         /**
-         * @see org.apache.james.pop3server.POP3HandlerConfigurationData#getResetLength()
-         */
-        public int getResetLength() {
-            return -1;
-        }
-
-        /**
-         * @see org.apache.james.pop3server.POP3HandlerConfigurationData#isStartTLSSupported()
+         * @see org.apache.james.pop3server.POP3HandlerConfiguration#isStartTLSSupported()
          */
         public boolean isStartTLSSupported() {
             return POP3Server.this.isStartTLSSupported();



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org