You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2020/12/08 22:34:06 UTC
[GitHub] [poi] MariusVolkhart opened a new pull request #205: Change XPWFPictureData#getChecksum() to return long instead of Long
MariusVolkhart opened a new pull request #205:
URL: https://github.com/apache/poi/pull/205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] MariusVolkhart commented on a change in pull request #205: Change XPWFPictureData#getChecksum() to return long instead of Long
Posted by GitBox <gi...@apache.org>.
MariusVolkhart commented on a change in pull request #205:
URL: https://github.com/apache/poi/pull/205#discussion_r538863717
##########
File path: src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFPictureData.java
##########
@@ -146,7 +146,7 @@ public int getPictureType() {
return 0;
}
Review comment:
Is this a change that is desired to go through a deprecation cycle?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on a change in pull request #205: Change XPWFPictureData#getChecksum() to return long instead of Long
Posted by GitBox <gi...@apache.org>.
pjfanning commented on a change in pull request #205:
URL: https://github.com/apache/poi/pull/205#discussion_r538861083
##########
File path: src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFPictureData.java
##########
@@ -146,7 +146,7 @@ public int getPictureType() {
return 0;
}
Review comment:
with public APIs, we need to go through a deprecation cycle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] MariusVolkhart closed pull request #205: Change XPWFPictureData#getChecksum() to return long instead of Long
Posted by GitBox <gi...@apache.org>.
MariusVolkhart closed pull request #205:
URL: https://github.com/apache/poi/pull/205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org