[GitHub] [guacamole-server] necouchman commented on a change in pull request #217: GUACAMOLE-414: Implement TLS Write Locking Callbacks

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #217: GUACAMOLE-414: Implement TLS Write Locking Callbacks
URL: https://github.com/apache/guacamole-server/pull/217#discussion_r264059878
 
 

 ##########
 File path: src/protocols/vnc/vnc.c
 ##########
 @@ -55,6 +56,64 @@
 
 char* GUAC_VNC_CLIENT_KEY = "GUAC_VNC";
 
+#ifdef ENABLE_VNC_TLS_LOCKING
+/**
+ * A callback function that is called by the VNC library prior to writing
+ * data to a TLS-encrypted socket.  This returns the rfbBool FALSE value
+ * if there's an error locking the mutex, or rfbBool TRUE otherwise.
+ * 
+ * @param rfb_client
+ *     The rfbClient for which to lock the TLS mutex.
+ *
+ * @returns
+ *     rfbBool FALSE if an error occurs locking the mutex, otherwise
+ *     TRUE.
+ */
+static rfbBool guac_vnc_lock_write_to_tls(rfbClient* rfb_client) {
+
+    // Retrieve the Guacamole data structures
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services