[GitHub] [commons-codec] aherbert commented on a change in pull request #35: [CODEC-280] Added strict decoding property to BaseNCodec.

[GitBox <gi...@apache.org>]

aherbert commented on a change in pull request #35: [CODEC-280] Added strict decoding property to BaseNCodec.
URL: https://github.com/apache/commons-codec/pull/35#discussion_r370947730
 
 

 ##########
 File path: src/test/java/org/apache/commons/codec/net/BCodecTest.java
 ##########
 @@ -157,6 +158,7 @@ public void testDecodeObjects() throws Exception {
     }
 
     @Test
+    @Ignore("CODEC-280: Disabled strict decoding by default. The BCodec uses the default so this test does not fail the impossible cases.")
 
 Review comment:
   The new behaviour is lenient. So that would be a behaviour change for BCodec and make this test redundant.
   
   I think that the new strict decoding property can be added here too so users have an option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services