You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/27 02:57:34 UTC
[kudu-CR] thirdparty: upgrade libunwind to 1.3.1
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13439
to review the following change.
Change subject: thirdparty: upgrade libunwind to 1.3.1
......................................................................
thirdparty: upgrade libunwind to 1.3.1
This fixes a bug[1] that prevents libunwind from being built with modern
versions of the gold and LLD linkers. The update includes one of our custom
patches, but not the other.
1. https://github.com/libunwind/libunwind/issues/58
Change-Id: If810954d80c63dca4b350defc2c1b915ad4d06f4
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch
M thirdparty/vars.sh
3 files changed, 2 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/13439/1
--
To view, visit http://gerrit.cloudera.org:8080/13439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If810954d80c63dca4b350defc2c1b915ad4d06f4
Gerrit-Change-Number: 13439
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] thirdparty: upgrade libunwind to 1.3.1
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13439 )
Change subject: thirdparty: upgrade libunwind to 1.3.1
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If810954d80c63dca4b350defc2c1b915ad4d06f4
Gerrit-Change-Number: 13439
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 May 2019 18:46:35 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: upgrade libunwind to 1.3.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13439 )
Change subject: thirdparty: upgrade libunwind to 1.3.1
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, known Java flakes.
--
To view, visit http://gerrit.cloudera.org:8080/13439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If810954d80c63dca4b350defc2c1b915ad4d06f4
Gerrit-Change-Number: 13439
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 May 2019 22:05:15 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: upgrade libunwind to 1.3.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13439 )
Change subject: thirdparty: upgrade libunwind to 1.3.1
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: If810954d80c63dca4b350defc2c1b915ad4d06f4
Gerrit-Change-Number: 13439
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] thirdparty: upgrade libunwind to 1.3.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13439 )
Change subject: thirdparty: upgrade libunwind to 1.3.1
......................................................................
thirdparty: upgrade libunwind to 1.3.1
This fixes a bug[1] that prevents libunwind from being built with modern
versions of the gold and LLD linkers. The update includes one of our custom
patches, but not the other.
1. https://github.com/libunwind/libunwind/issues/58
Change-Id: If810954d80c63dca4b350defc2c1b915ad4d06f4
Reviewed-on: http://gerrit.cloudera.org:8080/13439
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch
M thirdparty/vars.sh
3 files changed, 2 insertions(+), 46 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If810954d80c63dca4b350defc2c1b915ad4d06f4
Gerrit-Change-Number: 13439
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>