You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sophie Blee-Goldman <so...@confluent.io> on 2019/05/06 18:28:27 UTC
[VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Hi all,
I'd like to call for a vote on a minor KIP that adds a close() method to
the RocksDBConfigSetter interface of Streams.
Link:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter
This is important for users who have created RocksOBjects in
RocksDBConfigSetter#setConfig to avoid leaking off-heap memory
Thanks!
Sophie
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Posted by Sophie Blee-Goldman <so...@confluent.io>.
Thanks everyone for voting! Closing the vote on this KIP which passes with
three +1 (binding) from Guozhang, Bill, and Matthias, and two +1
(non-binding) from Kamal and John.
For those interested you can check out the PR here:
https://github.com/apache/kafka/pull/6697
On Tue, May 7, 2019 at 7:31 AM Guozhang Wang <wa...@gmail.com> wrote:
> +1 （binding）
>
> On Mon, May 6, 2019 at 6:44 PM Kamal Chandraprakash <
> kamal.chandraprakash@gmail.com> wrote:
>
> > +1 (non-binding). Thanks for the KIP.
> >
> > On Tue, May 7, 2019 at 3:50 AM Bill Bejeck <bb...@gmail.com> wrote:
> >
> > > Thanks for the KIP Sophie.
> > >
> > > +1(binding)
> > >
> > > On Mon, May 6, 2019 at 4:51 PM John Roesler <jo...@confluent.io> wrote:
> > >
> > > > Thanks, Sophie, I reviewed the KIP, and I agree this is the best /
> > > > only-practical approach.
> > > >
> > > > +1 (non-binding)
> > > >
> > > > On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax <
> matthias@confluent.io>
> > > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > >
> > > > >
> > > > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > I'd like to call for a vote on a minor KIP that adds a close()
> > method
> > > > to
> > > > > > the RocksDBConfigSetter interface of Streams.
> > > > > >
> > > > > > Link:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter
> > > > > >
> > > > > > This is important for users who have created RocksOBjects in
> > > > > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory
> > > > > >
> > > > > > Thanks!
> > > > > > Sophie
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Posted by Guozhang Wang <wa...@gmail.com>.
+1 （binding）
On Mon, May 6, 2019 at 6:44 PM Kamal Chandraprakash <
kamal.chandraprakash@gmail.com> wrote:
> +1 (non-binding). Thanks for the KIP.
>
> On Tue, May 7, 2019 at 3:50 AM Bill Bejeck <bb...@gmail.com> wrote:
>
> > Thanks for the KIP Sophie.
> >
> > +1(binding)
> >
> > On Mon, May 6, 2019 at 4:51 PM John Roesler <jo...@confluent.io> wrote:
> >
> > > Thanks, Sophie, I reviewed the KIP, and I agree this is the best /
> > > only-practical approach.
> > >
> > > +1 (non-binding)
> > >
> > > On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax <ma...@confluent.io>
> > > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > >
> > > >
> > > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote:
> > > > > Hi all,
> > > > >
> > > > > I'd like to call for a vote on a minor KIP that adds a close()
> method
> > > to
> > > > > the RocksDBConfigSetter interface of Streams.
> > > > >
> > > > > Link:
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter
> > > > >
> > > > > This is important for users who have created RocksOBjects in
> > > > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory
> > > > >
> > > > > Thanks!
> > > > > Sophie
> > > > >
> > > >
> > > >
> > >
> >
>
--
-- Guozhang
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Posted by Kamal Chandraprakash <ka...@gmail.com>.
+1 (non-binding). Thanks for the KIP.
On Tue, May 7, 2019 at 3:50 AM Bill Bejeck <bb...@gmail.com> wrote:
> Thanks for the KIP Sophie.
>
> +1(binding)
>
> On Mon, May 6, 2019 at 4:51 PM John Roesler <jo...@confluent.io> wrote:
>
> > Thanks, Sophie, I reviewed the KIP, and I agree this is the best /
> > only-practical approach.
> >
> > +1 (non-binding)
> >
> > On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax <ma...@confluent.io>
> > wrote:
> >
> > > +1 (binding)
> > >
> > >
> > >
> > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote:
> > > > Hi all,
> > > >
> > > > I'd like to call for a vote on a minor KIP that adds a close() method
> > to
> > > > the RocksDBConfigSetter interface of Streams.
> > > >
> > > > Link:
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter
> > > >
> > > > This is important for users who have created RocksOBjects in
> > > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory
> > > >
> > > > Thanks!
> > > > Sophie
> > > >
> > >
> > >
> >
>
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Posted by Bill Bejeck <bb...@gmail.com>.
Thanks for the KIP Sophie.
+1(binding)
On Mon, May 6, 2019 at 4:51 PM John Roesler <jo...@confluent.io> wrote:
> Thanks, Sophie, I reviewed the KIP, and I agree this is the best /
> only-practical approach.
>
> +1 (non-binding)
>
> On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax <ma...@confluent.io>
> wrote:
>
> > +1 (binding)
> >
> >
> >
> > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote:
> > > Hi all,
> > >
> > > I'd like to call for a vote on a minor KIP that adds a close() method
> to
> > > the RocksDBConfigSetter interface of Streams.
> > >
> > > Link:
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter
> > >
> > > This is important for users who have created RocksOBjects in
> > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory
> > >
> > > Thanks!
> > > Sophie
> > >
> >
> >
>
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Posted by John Roesler <jo...@confluent.io>.
Thanks, Sophie, I reviewed the KIP, and I agree this is the best /
only-practical approach.
+1 (non-binding)
On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax <ma...@confluent.io>
wrote:
> +1 (binding)
>
>
>
> On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote:
> > Hi all,
> >
> > I'd like to call for a vote on a minor KIP that adds a close() method to
> > the RocksDBConfigSetter interface of Streams.
> >
> > Link:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter
> >
> > This is important for users who have created RocksOBjects in
> > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory
> >
> > Thanks!
> > Sophie
> >
>
>
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1 (binding)
On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote:
> Hi all,
>
> I'd like to call for a vote on a minor KIP that adds a close() method to
> the RocksDBConfigSetter interface of Streams.
>
> Link:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter
>
> This is important for users who have created RocksOBjects in
> RocksDBConfigSetter#setConfig to avoid leaking off-heap memory
>
> Thanks!
> Sophie
>