You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/13 02:27:48 UTC

[GitHub] [commons-csv] belugabehr commented on a change in pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection

belugabehr commented on a change in pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#discussion_r668380832



##########
File path: src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
##########
@@ -132,10 +132,24 @@ int lookAhead() throws IOException {
      */
     char[] lookAhead(final int n) throws IOException {
         final char[] buf = new char[n];

Review comment:
       Actually, it's still used in `CSVFormat#printWithEscapes`.  I am happy to remove fully in another PR, but wanted to keep change as small as possible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org