You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/05/24 11:53:29 UTC
Review Request 70713: Renamed quota guarantee to be plural in the
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70713/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
This makes the naming consistent with the `QuotaConfig`
protobuf message.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 7e4f30d16010a777ff29ba35366ae80ff2631322
src/master/allocator/mesos/hierarchical.cpp ccca391fbf73d9aa9c31f7552e39fb78c242e242
Diff: https://reviews.apache.org/r/70713/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70713: Renamed quota guarantee to be plural in the
allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70713/
-----------------------------------------------------------
(Updated May 29, 2019, 8:24 a.m.)
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This makes the naming consistent with the `QuotaConfig`
protobuf message.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 71a9656fb934bf9ac58e3165254ea49cb09efa8b
src/master/allocator/mesos/hierarchical.cpp 40c8363afddccdd5275ca06318a8cc2cc6fa21af
Diff: https://reviews.apache.org/r/70713/diff/3/
Changes: https://reviews.apache.org/r/70713/diff/2-3/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70713: Renamed quota guarantee to be plural in the
allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70713/#review215510
-----------------------------------------------------------
Ship it!
nevermind :)
- Benjamin Mahler
On May 24, 2019, 11:53 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70713/
> -----------------------------------------------------------
>
> (Updated May 24, 2019, 11:53 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This makes the naming consistent with the `QuotaConfig`
> protobuf message.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 7e4f30d16010a777ff29ba35366ae80ff2631322
> src/master/allocator/mesos/hierarchical.cpp ccca391fbf73d9aa9c31f7552e39fb78c242e242
>
>
> Diff: https://reviews.apache.org/r/70713/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70713: Renamed quota guarantee to be plural in the
allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70713/#review215508
-----------------------------------------------------------
Does this match the quota protobuf?
- Benjamin Mahler
On May 24, 2019, 11:53 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70713/
> -----------------------------------------------------------
>
> (Updated May 24, 2019, 11:53 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This makes the naming consistent with the `QuotaConfig`
> protobuf message.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 7e4f30d16010a777ff29ba35366ae80ff2631322
> src/master/allocator/mesos/hierarchical.cpp ccca391fbf73d9aa9c31f7552e39fb78c242e242
>
>
> Diff: https://reviews.apache.org/r/70713/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>