You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/01/12 16:36:12 UTC

[GitHub] spark pull request #20163: [SPARK-22966][PYTHON][SQL] Python UDFs with retur...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20163#discussion_r161268321
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala ---
    @@ -144,6 +145,7 @@ object EvaluatePython {
         }
     
         case StringType => (obj: Any) => nullSafeConvert(obj) {
    +      case _: Calendar => null
           case _ => UTF8String.fromString(obj.toString)
    --- End diff --
    
    shall we blacklist more types? e.g. if a udf returns decimal and mark the return type as string type, is it a mismatch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org