You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2016/11/09 09:07:12 UTC

hbase git commit: HBASE-17039 SimpleLoadBalancer schedules large amount of invalid region moves

Repository: hbase
Updated Branches:
  refs/heads/master 03bc884ea -> 3b63f701e


HBASE-17039 SimpleLoadBalancer schedules large amount of invalid region moves

Signed-off-by: Yu Li <li...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/3b63f701
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/3b63f701
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/3b63f701

Branch: refs/heads/master
Commit: 3b63f701e67a91bf0d83b161dc0b13000b3b07a8
Parents: 03bc884
Author: Charlie Qiangeng Xu <ch...@yahoo.com>
Authored: Wed Nov 9 16:35:17 2016 +0800
Committer: Yu Li <li...@apache.org>
Committed: Wed Nov 9 17:04:16 2016 +0800

----------------------------------------------------------------------
 .../hadoop/hbase/master/balancer/SimpleLoadBalancer.java       | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/3b63f701/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
index fdcedf1..548a9a1 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
@@ -269,14 +269,10 @@ public class SimpleLoadBalancer extends BaseLoadBalancer {
         serversByLoad.entrySet()) {
       if (maxToTake == 0) break; // no more to take
       int load = server.getKey().getLoad();
-      if (load >= min && load > 0) {
+      if (load >= min) {
         continue; // look for other servers which haven't reached min
       }
       int regionsToPut = min - load;
-      if (regionsToPut == 0)
-      {
-        regionsToPut = 1;
-      }
       maxToTake -= regionsToPut;
       underloadedServers.put(server.getKey().getServerName(), regionsToPut);
     }