[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1473: Fix #1468 Intermittent failure of CamelDevModeTest

[GitBox <gi...@apache.org>]

ppalaga commented on a change in pull request #1473:
URL: https://github.com/apache/camel-quarkus/pull/1473#discussion_r453936422



##########
File path: extensions-core/main/runtime/src/main/java/org/apache/camel/quarkus/main/CamelMain.java
##########
@@ -77,6 +83,9 @@ protected void doStart() throws Exception {
     @Override
     protected void doStop() throws Exception {
         super.doStop();
+        /* Wait till the Camel shutdown is finished in its separate thread and proceed with subsequent Quarkus shutdown
+         * tasks only after that */
+        getShutdownStrategy().await(shutdownTimeoutMs, TimeUnit.MILLISECONDS);

Review comment:
       > @ppalaga shouldn't be better to put this `await` in `CamelMainRuntime::stop` metod ? here you are waiting to the shut-down before context.stop() is invoked
   
   Hm... if we do it that way, context.stop() will happen in parallel with CamelMain.beforeStop(), CamelMain.stop(), and CamelMain.afterStop(). Would that be the right thing to do?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org