You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2017/09/08 20:47:04 UTC
[GitHub] flink pull request #4662: [FLINK-7609][examples] WindowWordCount example doe...
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4662
[FLINK-7609][examples] WindowWordCount example doesn't print countWindow output with default configs
## What is the purpose of the change
When running WindowWordCount example with no params (using default params), no output is generated and thus printed, because the default 'window' and 'slide' value is too large (250 and 150).
The solution is to lower default 'window' and 'slide' values to probably 4 and 2
## Brief change log
Lower default 'window' and 'slide' values in this example to 4 and 2
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
I tested the example with updated default values, and it now generates and prints output.
## Does this pull request potentially affect one of the following parts:
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-7609
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4662
----
----
---
[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4662
lets go with 10/5 then.
---
[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4662
merging.
---
[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4662
@zentol and this one. Thanks!
---
[GitHub] flink pull request #4662: [FLINK-7609][examples] WindowWordCount example doe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4662
---
[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4662
Aren't these values a bit too low? (I'm specifically worried about cases where users supply their own data)
Would 100/50 maybe work?
---
[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4662
There's no output with 100/50 either, because the default text we use at WordCountData.WORDS is not very long and cannot satisfy the count window size. There's only 11 window ouputs even with 10/5, which are still a bigger size.
I prefer 4/2, but also think 10/5 is also ok, because the program is for demo purpose and new users would doubt the program's accuracy if it doesn't generate enough output. What do you think? @zentol
---
[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4662
@zentol Done
---