[GitHub] [hbase] anoopsjohn commented on a change in pull request #3474: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #3474:
URL: https://github.com/apache/hbase/pull/3474#discussion_r668025441



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##########
@@ -79,7 +79,7 @@ public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching,
       boolean repeat, boolean updateCacheMetrics) {
     // TODO: is there a hole here, or just awkwardness since in the lruCache getBlock
     // we end up calling l2Cache.getBlock.
-    return lruCache.containsBlock(cacheKey)?
+    return cacheKey.getBlockType().getCategory() == BlockCategory.DATA?

Review comment:
       In CombinedBC, its the NON data block (index/bloom) which goes to onheap LRU cache.  Data blocks go to bucket cache (l2Cache as per variable here)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org