[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1139: For https naming service, use 443 as default port

[GitBox <gi...@apache.org>]

jamesge commented on a change in pull request #1139:
URL: https://github.com/apache/incubator-brpc/pull/1139#discussion_r459977354



##########
File path: src/brpc/details/naming_service_thread.cpp
##########
@@ -38,6 +46,15 @@ struct NSKey {
           const std::string& service_in,
           const ChannelSignature& sig)
         : protocol(prot_in), service_name(service_in), channel_signature(sig) {
+        if (CompareStringPieceWithoutCase(protocol, "https") &&

Review comment:
       看上去是可以的，DomainNamingService的ctor加个参数就行了。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org