You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2007/03/03 17:10:50 UTC
[jira] Created: (OFBIZ-771) Refactor Webtools UI
Refactor Webtools UI
--------------------
Key: OFBIZ-771
URL: https://issues.apache.org/jira/browse/OFBIZ-771
Project: OFBiz (The Open for Business Project)
Issue Type: Sub-task
Components: framework
Reporter: Adrian Crum
Priority: Minor
Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-771:
------------------------------
Attachment: cache_pages.patch
Webtools cache pages patch from Joe Eckard. Tested by Adrian. This patch is ready for committment - it's not blocked by any other issues.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-771:
------------------------------
Attachment: webtools.patch
Attached patch is the first sweep through the Webtools component.
All of this has been tested EXCEPT:
Work With Data Files (https://127.0.0.1:8443/webtools/control/viewdatafile)
and
Workflow Monitor (https://127.0.0.1:8443/webtools/control/workflowMonitor).
I couldn't find test data or sufficient info to test them.
This effort ended up being much more work than I anticipated. I converted the JSPs to screen widgets. I started to remove the deprecated styles and such, but it was taking me a while and I know others are waiting on this being committed so they can do additional work on the component.
I'll create new sub tasks for the UI work that remains.
Remaining UI work: finish removing deprecated styles, convert table-based layout to screenlets, convert embedded text to UI label properties.
Many thanks to Joe Eckard, David Jones, and Andrew Zeneski for their help with this.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484476 ]
Adrian Crum commented on OFBIZ-771:
-----------------------------------
Jacopo,
cache_pages.patch was included in the webtools patch/zip file. No need to commit it separately. Thank you very much for your help!
This issue can be closed. I will create new ones to finish the steps I outlined previously.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Assigned To: Jacopo Cappellato
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch, webtools.zip
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478288 ]
Jacopo Cappellato commented on OFBIZ-771:
-----------------------------------------
Adrian,
thanks for this work that in my opinion is very important since the webtools application is the last one that is still not compltely based on screen widgets.
Would it be possible for you to divide your work on smaller stable (i.e. that can be committed) patches? For example, one patch for the "stats" pages conversion from jsp->widget would be great.
On the other hand, if you are at the dev conference and there are committers there willing to help getting this committed, that would be great and ignore my comment here.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479803 ]
Adrian Crum commented on OFBIZ-771:
-----------------------------------
I'm happy just to get the JSPs out of the component. If someone would like to change the parameter names or (as David Jones suggested) convert it all to form widgets, they are welcome to do so.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-771) Refactor Webtools UI
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reassigned OFBIZ-771:
---------------------------------------
Assignee: Jacopo Cappellato
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Assigned To: Jacopo Cappellato
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch, webtools.zip
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-771:
------------------------------
Attachment: webtools.patch
Attached patch is incomplete. Posted here so Chris Howe can proceed with his work on March 10. This patch is not intended to be included in the project. The complete, final version will be posted in the next few days.
Chris - patch contains duplicate copies of some files due to a bug in my SVN client.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479804 ]
Chris Howe commented on OFBIZ-771:
----------------------------------
Cool, perhaps a minor issue for some other time then. Thanks for finally clearing the JSPs out!
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478436 ]
Adrian Crum commented on OFBIZ-771:
-----------------------------------
Jacopo,
Joe Eckerd is here and he is helping me with this. Once the work is complete, I can break up the patches into smaller pieces. Right now we're just passing them back and forth.
Could you take a look at the blocker issue please?
-Adrian
"Jacopo Cappellato (JIRA)" <ji...@apache.org> wrote:
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478288 ]
Jacopo Cappellato commented on OFBIZ-771:
-----------------------------------------
Adrian,
thanks for this work that in my opinion is very important since the webtools application is the last one that is still not compltely based on screen widgets.
Would it be possible for you to divide your work on smaller stable (i.e. that can be committed) patches? For example, one patch for the "stats" pages conversion from jsp->widget would be great.
On the other hand, if you are at the dev conference and there are committers there willing to help getting this committed, that would be great and ignore my comment here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------
Cheap Talk? Check out Yahoo! Messenger's low PC-to-Phone call rates.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483925 ]
Jacopo Cappellato commented on OFBIZ-771:
-----------------------------------------
Adrian,
I can really understand how much work you did! Thanks.
I know that I'm asking something out of the best practices but, would it be possible for you to attach the full zipped webtools folder that you used to create the diff file?
Due to some limitations on my patch tool this would greatly speed up things for me.
Thanks again,
Jacopo
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484341 ]
Jacopo Cappellato commented on OFBIZ-771:
-----------------------------------------
Should I commit also cache_pages.patch?
Or can we close this issue?
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Assigned To: Jacopo Cappellato
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch, webtools.zip
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484340 ]
Jacopo Cappellato commented on OFBIZ-771:
-----------------------------------------
Adrian, all,
webtools.patch is in rev. 522793 + some misc cleanups in rev. 522799 and 522802
Let me know if you see something wrong.
Many thanks to Adrian (et all) for this great contribution.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Assigned To: Jacopo Cappellato
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch, webtools.zip
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-771:
------------------------------
Attachment: webtools.zip
Zip file that Jacopo requested.
Jacopo - have you tried using TortoiseSVN?
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch, webtools.zip
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479802 ]
Chris Howe commented on OFBIZ-771:
----------------------------------
Thanks Adrian!
This will work well for me in the morning.
Quick, trivial question: parameter names; Wasn't there a lazy effort a while back to change from THIS_PARAMETER to thisParameter? Do we have a set convention on this?
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-771) Refactor Webtools UI
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-771.
-----------------------------------
Resolution: Fixed
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Assigned To: Jacopo Cappellato
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch, webtools.patch, webtools.zip
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-771) Refactor Webtools UI
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-771:
------------------------------
Attachment: webtools.patch
Preliminary patch - not intended for committing. Attached here for collaboration.
All stats pages are done. Currently working on jobs pages.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-771) Refactor Webtools UI
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479922 ]
Jacopo Cappellato commented on OFBIZ-771:
-----------------------------------------
As part of this effeort, it would be nice to update (or remove) the long text message that appears to non logged in users.
> Refactor Webtools UI
> --------------------
>
> Key: OFBIZ-771
> URL: https://issues.apache.org/jira/browse/OFBIZ-771
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: cache_pages.patch, webtools.patch, webtools.patch
>
>
> Refactor the Webtools UI to utilize the new CSS styles and widgets. Convert existing JSPs to widgets.
> This sub-task might take me a while because of the JSP conversion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.