You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2018/05/19 07:26:20 UTC

[jclouds/jclouds-karaf] upgrade to java 8 (#108)

- bump guava version to 21
- bump karaf version to 4.2.0 to support java 8/9/10
- fix karaf-maven-plugin to use javase 1.8

this is required for https://github.com/jclouds/jclouds-labs/pull/436
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-karaf/pull/108

-- Commit Summary --

  * upgrade to java 8

-- File Changes --

    M cache/src/main/java/org/jclouds/karaf/cache/utils/CacheUtils.java (4)
    M chef/services/src/main/java/org/jclouds/karaf/chef/services/Activator.java (2)
    M commands/src/main/java/org/jclouds/karaf/commands/blobstore/BlobExistsCommand.java (11)
    M commands/src/main/java/org/jclouds/karaf/commands/blobstore/BlobReadCommand.java (4)
    M feature-labs/pom.xml (2)
    M feature/pom.xml (2)
    M feature/src/main/feature/feature.xml (1)
    M pom.xml (10)

-- Patch Links --

https://github.com/jclouds/jclouds-karaf/pull/108.patch
https://github.com/jclouds/jclouds-karaf/pull/108.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

Posted by Andrea Turli <no...@github.com>.
@nacx I'd appreciate your test as the ASF builder is reporting a weird problem I cannot reproduce locally, thanks!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-390484944

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

Posted by Andrea Turli <no...@github.com>.
rebuild please


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-390401266

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

Posted by Ignasi Barrera <no...@github.com>.
According to [this](http://karaf.922171.n3.nabble.com/compilation-failing-with-karaf-4-2-0-M2-td4052701.html) it looks like that Maven >= 3.3.x is needed for the `karaf-maven-plugin` which we use to validate the features can be installed.
I'd suggest configuring the `maven-enforcer-plugin` in the jclouds-jaraf project to require such a Maven version and include the change in this PR.
@andreaturli @gaul WDYT?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-391021542

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

Posted by Andrea Turli <no...@github.com>.
I think `maven-enforcer-plugin` config comes from jclouds/jclouds, do we want to override only for `jclouds/jclouds-jaraf` ?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-391025126

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

Posted by Ignasi Barrera <no...@github.com>.
rebuild please

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-391017105