[GitHub] [ignite-3] sanpwc commented on a change in pull request #207: IGNITE-14841 Use shared distruptor pool for multiple raft group nodes

[GitBox <gi...@apache.org>]

sanpwc commented on a change in pull request #207:
URL: https://github.com/apache/ignite-3/pull/207#discussion_r679735388



##########
File path: modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JRaftServerImpl.java
##########
@@ -123,6 +128,38 @@ public JRaftServerImpl(
             JRaftUtils.createRequestExecutor(opts)
         );
 
+        if (opts.getfSMCallerExecutorDisruptor() == null) {
+            opts.setfSMCallerExecutorDisruptor(new StripedDisruptor<FSMCallerImpl.ApplyTask>(
+                "JRaft-FSMCaller-Disruptor",
+                opts.getRaftOptions().getDisruptorBufferSize(),

Review comment:
       Could you please clarify purposes of each disraptor?

##########
File path: modules/raft/src/main/java/org/apache/ignite/raft/jraft/JRaftUtils.java
##########
@@ -49,10 +53,50 @@
      * @return true if bootstrap success
      */
     public static boolean bootstrap(final BootstrapOptions opts) throws InterruptedException {
-        final NodeImpl node = new NodeImpl();
+        final NodeImpl node = new NodeImpl("unittest", new PeerId("127.0.0.1", 0));

Review comment:
       Am I right that JRaftUtils isn't a part of test package? If true it's strange to see "unittest" and "new PeerId("127.0.0.1", 0)" here. Is there any sense in bootstrap method in non-test environment? If not, did you consider moving bootstrap to test env?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org