You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by amichalowski <gi...@git.apache.org> on 2016/11/05 17:13:16 UTC
[GitHub] wicket pull request #187: Add origin header to ajax requests in BaseWicketTe...
GitHub user amichalowski opened a pull request:
https://github.com/apache/wicket/pull/187
Add origin header to ajax requests in BaseWicketTester
In commits assigned to this issue:
[https://issues.apache.org/jira/browse/WICKET-6245](https://issues.apache.org/jira/browse/WICKET-6245)
There are following changes in `CsrfPreventionRequestCycleListener`:
- If origin header doesn't exist referer header can be used.
- Default no origin behavior was changed to abort.
But the wicket tester doesn't send Origin or Referer header.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amichalowski/wicket wicket-tester-origin-header
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit 893579c88c98b8dfbc6612ff7c2e1b3ac024e6f6
Author: Artur Micha\u0142owski <am...@gmail.com>
Date: 2016-11-05T16:59:56Z
Add origin header to ajax requests in BaseWicketTester
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/187
Merged!
Thank you, @amichalowski !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/187
I think this should be merged before 7.5.1/7.6.0.
@papegaaij , @dashorst WDYT ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #187: Add origin header to ajax requests in BaseWicketTe...
Posted by amichalowski <gi...@git.apache.org>.
Github user amichalowski closed the pull request at:
https://github.com/apache/wicket/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/187
Please close this issue!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/187
+1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by dashorst <gi...@git.apache.org>.
Github user dashorst commented on the issue:
https://github.com/apache/wicket/pull/187
7.6 is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/187
https://issues.apache.org/jira/browse/WICKET-6274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by papegaaij <gi...@git.apache.org>.
Github user papegaaij commented on the issue:
https://github.com/apache/wicket/pull/187
I think this is nice to have, but not crucial. I'd go for 7.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/187
@amichalowski Ping!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #187: Add origin header to ajax requests in BaseWicketTester
Posted by amichalowski <gi...@git.apache.org>.
Github user amichalowski commented on the issue:
https://github.com/apache/wicket/pull/187
closed;
thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---