You are viewing a plain text version of this content. The canonical link for it is here.

Posted to fop-dev@xmlgraphics.apache.org by Paul Vinkenoog <pa...@vinkenoog.nl> on 2007/03/28 13:23:22 UTC

PDFGoTo: setXPosition and setYPosition

Hi all,

org.apache.fop.pdf.PDFGoTo currently has the following position
setters:

    public void setYPosition(float yPosition) {
        this.yPosition = yPosition;
    }

    public void setXPosition(int xPosition) {
        this.xPosition = (xPosition / 1000f);
    }

This seems a little inconsistent to me.

setYPosition is called from the PDFRenderer, setXPosition isn't called
from anywhere at all in the FOP sources.

Since PDFGoTo.java is included in my upcoming basic-links patch
proposal anyway, shall I make setXPosition consistent with
setYPosition (accepting float, no division by 1000)?


Kind regards,
Paul Vinkenoog

Re: PDFGoTo: setXPosition and setYPosition

Posted by Andreas L Delmelle <a_...@pandora.be>.

On Mar 28, 2007, at 13:23, Paul Vinkenoog wrote:

Hi Paul,

> org.apache.fop.pdf.PDFGoTo currently has the following position
> setters:
>
>     public void setYPosition(float yPosition) {
>         this.yPosition = yPosition;
>     }
>
>     public void setXPosition(int xPosition) {
>         this.xPosition = (xPosition / 1000f);
>     }
>
> This seems a little inconsistent to me.

A 'little', you say... :/

AFAICT, you can safely change the signature and implementation for  
setXPosition().


Cheers,

Andreas