[GitHub] [nifi-minifi-cpp] lordgamez edited a comment on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6

[GitBox <gi...@apache.org>]

lordgamez edited a comment on pull request #963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-747074012


   Summary of the issue from what I gathered:
   
   - There are incompatible changes between the Lua 5.3 and 5.4 API that causes the build failure, see 8.3 of the [Lua 5.4 reference](https://www.lua.org/manual/5.4/manual.html)
   - Even though sol2 library bumped the valid Lua version to 5.4 in sol2 2.20.3 it was just [experimental ](https://github.com/ThePhD/sol2/issues/649)it does not guarantee compatibility.
   - Lua 5.4 compatibility was introduced in sol2 v3.2.0, but sol2 v3.0+ versions make use of the c++17 and c++20 language feature and thus requires GCC 7.x.x and Clang 3.9.x compilers. Because of this we cannot upgrade to that version.
   
   We need to revisit the upgrade after we reach the required compiler version. Until then I do not see any advantage of the version upgrade.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org