[GitHub] [parquet-mr] fschmalzel commented on a change in pull request #870: PARQUET-1984: Allow tests to run on windows

[GitBox <gi...@apache.org>]

fschmalzel commented on a change in pull request #870:
URL: https://github.com/apache/parquet-mr/pull/870#discussion_r579050976



##########
File path: parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestInputFormat.java
##########
@@ -398,7 +399,10 @@ public void testGetFootersReturnsInPredictableOrder() throws IOException {
       if (i > 0) {
         url.append(',');
       }
-      url.append("file:").append(file.getAbsolutePath());
+      if (!SystemUtils.IS_OS_WINDOWS) {
+        url.append("file:");
+      }
+      url.append(file.getAbsolutePath());

Review comment:
       I've changed this test to use URIs instead. Now it should work platform independent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org