[GitHub] [kafka] guozhangwang commented on a diff in pull request #12458: MINOR: Adds KRaft versions of most streams system tests

[GitBox <gi...@apache.org>]

guozhangwang commented on code in PR #12458:
URL: https://github.com/apache/kafka/pull/12458#discussion_r937256375


##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -205,11 +212,17 @@ def collect_results(self, sleep_time_secs):
         return data
 
     @cluster(num_nodes=7)
+    @matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce", "hard_bounce"],
+            broker_type=["leader"],
+            num_threads=[1, 3],
+            sleep_time_secs=[120],
+            metadata_quorum=[quorum.remote_kraft])

Review Comment:
   Why we only want to test remote_kraft but not collocated kraft?



##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -251,8 +264,9 @@ def test_broker_type_bounce_at_start(self, failure_mode, broker_type, sleep_time
 
     @cluster(num_nodes=7)
     @matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce", "hard_bounce"],
-            num_failures=[2])
-    def test_many_brokers_bounce(self, failure_mode, num_failures):
+            num_failures=[2],
+            metadata_quorum=quorum.all_non_upgrade)
+    def test_many_brokers_bounce(self, failure_mode, num_failures, metadata_quorum=quorum.zk):

Review Comment:
   nit: since we already set the value range of `metadata_quorum` in the matrix, do we still need to set its default as `quorum.zk`? Seems the default value would never be used? Ditto elsewhere.



##########
tests/kafkatest/tests/streams/streams_static_membership_test.py:
##########
@@ -50,8 +55,10 @@ def __init__(self, test_context):
                                            acks=1)
 
     @cluster(num_nodes=8)
-    def test_rolling_bounces_will_not_trigger_rebalance_under_static_membership(self):
-        self.zookeeper.start()

Review Comment:
   Should we do this change in `streams_cooperative_rebalance_upgrade_test` also?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org