You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by RoddieKieley <gi...@git.apache.org> on 2017/12/07 15:35:15 UTC
[GitHub] qpid-proton pull request #131: PROTON-1711: SSL_IMPL none SASL_IMPL none bui...
GitHub user RoddieKieley opened a pull request:
https://github.com/apache/qpid-proton/pull/131
PROTON-1711: SSL_IMPL none SASL_IMPL none build attempts to build c-s…
…sl-tests and fails
Added simple check to only build c-ssl-tests if SSL_IMPL was not none.
NOTE: This simple change also exposes the fact that the python binding does not build with SSL_IMPL none and all other configuration variables default at the moment. I disabled the python binding for a successful build as I didn't need it at the moment.
Should be addressed here or via separate issue?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RoddieKieley/qpid-proton PROTON-1711
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit 84f2ae514606fb69e6f985f911d4a966c20fc75a
Author: circleci <ci...@mail.com>
Date: 2017-12-07T15:28:07Z
PROTON-1711: SSL_IMPL none SASL_IMPL none build attempts to build c-ssl-tests and fails
Added simple check to only build c-ssl-tests if SSL_IMPL was not none.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #131: PROTON-1711: SSL_IMPL none SASL_IMPL none build atte...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/131
Oops - I guess I did that when I added in the ssl tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #131: PROTON-1711: SSL_IMPL none SASL_IMPL none build atte...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/131
@RoddieKieley I've fixed this issue now - can you close the PR (stupidly I forgot to add that to the commit).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #131: PROTON-1711: SSL_IMPL none SASL_IMPL none bui...
Posted by RoddieKieley <gi...@git.apache.org>.
Github user RoddieKieley closed the pull request at:
https://github.com/apache/qpid-proton/pull/131
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #131: PROTON-1711: SSL_IMPL none SASL_IMPL none build atte...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/131
The tests should still pass if SSL_IMPL is none as there is a stub implementation. If not then we need to fix that bug.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org