[jira] Updated: (TAP5-1047) @IncludeJavaScriptLibrary and @IncludeStylesheet may incorrectly calculate resources in component sub-classes

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-1047:
---------------------------------------

    Description: 
The recent refactoring of ComponentClassTransformWorkers is suspect. I believe that the workers for the two annotations are using the component;s componentResources to get to the base resource, rather than capturing the correct base resource at transformation time.  The former means that the base resource used is derived from the subclass, the latter is that the base resource is derived (correctly) from the super-class.




  was:
Since february 20th 2 problems have been introduced when extending the Autocomplete mixin.

- The mixin will try to load the autocomplete.js from the classpath location of the extending class, in stead of the Autocomplete.class
- The @Override methods (eg. generateResponseMarkup(MarkupWriter writer, List matches)) are no longer called on the extending class

I have been using my extended version for about 18 months without problems and suspect it might have something to do with the move away from javassist.

        Summary: @IncludeJavaScriptLibrary and @IncludeStylesheet may incorrectly calculate resources in component sub-classes  (was: extending Autocomplete no longer works)

- The @Override methods (eg. generateResponseMarkup(MarkupWriter writer, List matches)) are no longer called on the extending class


I can't see this as being true; it's clearly in the code that the method is being called and can be overridden.

> @IncludeJavaScriptLibrary and @IncludeStylesheet may incorrectly calculate resources in component sub-classes
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1047
>                 URL: https://issues.apache.org/jira/browse/TAP5-1047
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0
>            Reporter: Joost Schouten
>            Assignee: Howard M. Lewis Ship
>
> The recent refactoring of ComponentClassTransformWorkers is suspect. I believe that the workers for the two annotations are using the component;s componentResources to get to the base resource, rather than capturing the correct base resource at transformation time.  The former means that the base resource used is derived from the subclass, the latter is that the base resource is derived (correctly) from the super-class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.