[GitHub] [metron] merrimanr opened a new pull request #1436: METRON-2149: Shaded jar classifier is not consistent

[GitBox <gi...@apache.org>]

merrimanr opened a new pull request #1436: METRON-2149: Shaded jar classifier is not consistent
URL: https://github.com/apache/metron/pull/1436
 
 
   ## Contributor Comments
   This PR updates the appropriate Maven pom.xml files to use a classifier when building shaded jars.  After this change all shaded jars will follow the pattern `${project.artifactId}-${project.version}-uber.jar` whereas before some jars would follow this pattern while others would follow `${project.artifactId}-${project.version}.jar`.
   
   I believe this will provide a substantial benefit to the project because it will alleviate 2 significant issues.  When a module that uses the shaded plugin without a classifier is added to another module as a dependency:
   
   1. Any Maven excludes added to that dependency are ignored
   2. The Maven dependency:tree tool does not accurately report the transitive dependencies pulled in by that dependency
   
   These issues make it extremely difficult to troubleshoot and resolve classpath version problems.  
   
   ### Changes Included
   
   - Appropriate modules were updated to use a classifier
   - Scripts and RPM spec files were updated with the new jar names
   - New classpath version issues introduced with this change were fixed
   - Minor formatting issues were fixed in a couple pom files
   
   ### Testing
   
   I have done some initial testing in full dev.  Full dev should start up without error, there should be data in the Alerts UI, and there should be no errors in the Storm logs.  I also did some light testing of the scripts in `$METRON_HOME/bin/` to ensure there were no jar name errors (`Error: Could not find or load main class ...`).  There was an issue with `latency_summarizer.sh` but it looks like this has not been maintained and doesn't work in master anyways.  Should we resolve that here?
   
   There is likely more testing we'll want to do to ensure classpath version errors were not introduced but this is a start.  
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   
   ### For code changes:
   - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [x] Have you included steps or a guide to how the change may be verified and tested manually?
   - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [x] Have you written or updated unit tests and or integration tests to verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions.
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services